sotw: [#558] Support dynamic wildcard subscription in sotw-xds #571
Conversation
…ard mode Signed-off-by: Valerian Roche <valerian.roche@datadoghq.com>
Signed-off-by: Valerian Roche <valerian.roche@datadoghq.com>
Signed-off-by: Valerian Roche <valerian.roche@datadoghq.com>
Signed-off-by: Valerian Roche <valerian.roche@datadoghq.com>
Signed-off-by: Valerian Roche <valerian.roche@datadoghq.com>
valerian-roche
force-pushed
the
vr/sotw-wildcard
branch
from
a4cde15 to
2eb2a43
Compare
|
Ah this is awesome thanks @valerian-roche. I'll start the review process on this now. Would you mind resolving those merge conflicts? |
|
Hey @alecholmez |
|
@fxposter given our conversations in slack I think this is now nullified if we don't want to track state in sotw. Can you review real quick and confirm? |
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
|
This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
Akin to #559, this PR is adding support for the new envoy wildcard semantics in the context of the SOTW server
It is also doing significant work merging logic between the delta and sotw parts, especially for shared objects like StreamState where we currently have different members representing the same functional concern based on the server used
The PR is quite large mainly due to:
map[string]boolandmap[string]struct{}. An implementation choice here was to align onmap[string]struct{}to not alter delta as much as possible, but the revert can be doneI can rework it in multiple smaller PRs to handle some parts independently (mostly aligning the maps) if preferred by reviewers